-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rule and aspect validation output groups #19630
Conversation
By merging the special `_validation` output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions.
e7d115e
to
caef2f8
Compare
Awesome, thanks for jumping on this so quickly! |
cc @comius |
cc @lberki |
@bazel-io flag |
@bazel-io fork 6.4.0 |
@fmeum @ahumesky @lberki @ismell There were some conflicts when cherry-picking this to release-6.4.0.
is in release-6.4.0 branch. But expected below before the cherry-pick
Also, cc: @bazelbuild/triage |
By merging the special `_validation` output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions. Fixes bazelbuild#19624 Closes bazelbuild#19630. PiperOrigin-RevId: 571084964 Change-Id: I3135ce1f9e61124e96a3b7d8e0ea0c3a3cdf526d Fixes bazelbuild#19742
@iancha1992 I performed a manual cherry-pick in #19745. |
Thanks! |
By merging the special
_validation
output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions.Fixes #19624